Add range_qname and range_value methods to Attribute.
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To save memory this only uses two `u8`s per `Attribute`, but the tradeoff is that the qname and value ranges will be incorrect in a few extreme data cases, specifically if the attribute's qname has len > 255 or there are >254 spaces surrounding its equal sign. Those cases seem unlikely enough in practice to justify not using more memory for this.
RazrFalcon
reviewed
May 22, 2024
RazrFalcon
reviewed
May 22, 2024
RazrFalcon
reviewed
May 22, 2024
RazrFalcon
reviewed
May 22, 2024
RazrFalcon
reviewed
May 22, 2024
RazrFalcon
reviewed
May 22, 2024
RazrFalcon
reviewed
May 22, 2024
… `u16`, PR comments.
Jayonas
changed the title
positions-extra-attr feature for Attribute subranges.range_qname and range_value methods to Attribute.
|
Thanks! Looks good to me. Is that all or do you plan any other changes? If no then I will publish a new release. |
|
Nope, not planning any other changes right now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To save memory this only uses a
u16andu8perAttribute, but the tradeoff is that the qname and value ranges will be incorrect in a few extreme data cases, specifically if the attribute's qname has len > 65535 or there are >254 spaces surrounding its equal sign. Those cases seem unlikely enough in practice to justify not using more memory for this.