Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foverlaps: better error message when intervals have NA #3418

Merged
merged 4 commits into from
Feb 18, 2019

Conversation

arunsrinivasan
Copy link
Member

Closes #3007.

@codecov
Copy link

codecov bot commented Feb 17, 2019

Codecov Report

Merging #3418 into master will decrease coverage by 0.1%.
The diff coverage is 92.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
- Coverage   95.12%   95.02%   -0.11%     
==========================================
  Files          65       65              
  Lines       12127    12249     +122     
==========================================
+ Hits        11536    11639     +103     
- Misses        591      610      +19
Impacted Files Coverage Δ
R/foverlaps.R 97.98% <76.92%> (-2.02%) ⬇️
src/ijoin.c 94.66% <95.71%> (-2.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c43750...0691e9c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 17, 2019

Codecov Report

Merging #3418 into master will decrease coverage by 0.1%.
The diff coverage is 92.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
- Coverage   95.12%   95.02%   -0.11%     
==========================================
  Files          65       65              
  Lines       12127    12249     +122     
==========================================
+ Hits        11536    11639     +103     
- Misses        591      610      +19
Impacted Files Coverage Δ
R/foverlaps.R 97.98% <76.92%> (-2.02%) ⬇️
src/ijoin.c 94.66% <95.71%> (-2.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c43750...0691e9c. Read the comment docs.

@arunsrinivasan arunsrinivasan merged commit 224906f into master Feb 18, 2019
@arunsrinivasan arunsrinivasan deleted the foverlaps-better-error-message-3007 branch February 18, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant