Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve strptime wrapper warning message #3776

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Aug 18, 2019

Closes #2068

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #3776 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3776   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          71       71           
  Lines       13225    13225           
=======================================
  Hits        13148    13148           
  Misses         77       77
Impacted Files Coverage Δ
R/data.table.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f1dfe...18a8bc1. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Aug 28, 2019
@mattdowle mattdowle changed the title Closes #2068 -- improve strptime wrapper warning message Improve strptime wrapper warning message Aug 28, 2019
@mattdowle mattdowle merged commit 4db0943 into master Aug 28, 2019
@MichaelChirico MichaelChirico deleted the incidental_strptime branch December 20, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confusing POSIXlt warning
2 participants