Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adv360 z3.2 3 #16

Closed
wants to merge 6 commits into from
Closed

Conversation

oselvaraj
Copy link

@oselvaraj oselvaraj commented Mar 8, 2024

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@ReFil
Copy link
Owner

ReFil commented Mar 13, 2024

Thankl you for this, I have a few notes:

1: ZMK doesn't support more than 32 layers, please trim the colour list back to 32 colours
2: Please document somewhere, maybe in a .md file somewhere what the colours are supposed to be
3: Please fix the pre-commit failures

@ReFil
Copy link
Owner

ReFil commented Apr 8, 2024

Closing in favour of #18

@ReFil ReFil closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants