Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #21

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix CI #21

merged 1 commit into from
Apr 10, 2024

Conversation

khoek
Copy link

@khoek khoek commented Apr 10, 2024

I think this should fix the CI matrix and get the modules building.

@ReFil
Copy link
Owner

ReFil commented Apr 10, 2024

I think the reason the push CI isn't working is related to this: zmkfirmware#2262, as this does work for build-use-config yml usage, but this is a good fix in the meantime, thanks again!

@ReFil ReFil merged commit b2ea092 into ReFil:adv360-z3.5 Apr 10, 2024
9 checks passed
@ReFil
Copy link
Owner

ReFil commented Apr 10, 2024

Yeah the upstream bug is still present and push builds are still failing unfortunately :/

@khoek khoek deleted the ci-fix branch April 11, 2024 01:55
@khoek
Copy link
Author

khoek commented Apr 11, 2024

Ah, that's a shame. At least I believe CI for pulls is actually working now.

ReFil pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants