Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options CONFIG_ZMK_BLE_INDICATOR_AUTO_OFF and CONFIG_ZMK_HANDLE_BLE_DISCONNECTION #9

Open
wants to merge 7 commits into
base: adv360-z3.2-beta
Choose a base branch
from

Conversation

cvcore
Copy link

@cvcore cvcore commented Oct 3, 2023

This PR addresses the following issues / improvements:

  1. The keyboard will keep reconnecting itself to the computer, even if the user disconnects it manually from the bluetooth menu.
  2. Add an option to allow the keyboard to switch on the profile indicator only during profile switches / bluetooth connection establishment.

This PR is a combination of the previous two (#7 & #8) to ease review and merging.

joelspadin and others added 7 commits September 8, 2023 09:18
Changed the endpoints code to rename the existing endpoint types to
"transport" and add the concept of "endpoint instances". A transport is
the method by which data is sent, while instances allow describing
multiple endpoints that use the same transport (e.g. bluetooth profiles)

Also added new APIs to get the total number of possible endpoint
instances and assign each instance a unique index, which can be used
for tracking separate state for each endpoint in other code files.
feat(lighting): Kinesis lighting functionality

moved peripheral updating from behaviour bnased to dedicated bluetooth services, added custom lighting effects to the adv360

Battery life improvements

Change default settings

Dim brightness of LEDS for improved battery life, Decrease settings save timeout to 29.5 seconds so it occurs before idle timeout

fix(lighting): fix initial power on lighting

Fix profile 5 behaviour

fix(underglow): fix RGB startup

fix(zephyr): update new includes

refactor(ble): Match new kconfigs

refactor(ble): Match new kconfigs
* fix(backlight/tests): Restore original behaviour to fix backlight tests

* fix(build): Remove feature-specific code when SPLIT_BLE, RGB_UNDERGLOW or BACKLIGHT isn't enabled

* refactor(bluetooth): Add battery reporting config.

* Add dedicated battery reporting Kconfig that is `imply`d by
  enabling ZMK_BLE.

* fix(rgb_underglow): Use correct condition in service.c

* Revert "refactor(bluetooth): Add battery reporting config."

This reverts commit 881da25.

---------

Co-authored-by: Peter Johanson <peter@peterjohanson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants