Skip to content
This repository has been archived by the owner on Oct 26, 2024. It is now read-only.

logging improvements #222

Merged
merged 54 commits into from
Nov 29, 2022
Merged

logging improvements #222

merged 54 commits into from
Nov 29, 2022

Commits on Nov 21, 2022

  1. fix for UI freezing when using ReturnYouTubeDislike

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    5affc28 View commit details
    Browse the repository at this point in the history

  2. synchronization data used by multiple threads. consolidated some code.

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    cf19d23 View commit details
    Browse the repository at this point in the history

  3. increase get dislikes timeout to 5 seconds.

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    80cf820 View commit details
    Browse the repository at this point in the history

  4. class probably should have a unique name

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    084630d View commit details
    Browse the repository at this point in the history

  5. verify network calls are not made from the main thread.

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7ed07a1 View commit details
    Browse the repository at this point in the history

  6. rename field

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    09d45f7 View commit details
    Browse the repository at this point in the history

  7. pass in a typed enum, instead of a plain int

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    97462d4 View commit details
    Browse the repository at this point in the history

  8. check for null parameters

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    98a3ecf View commit details
    Browse the repository at this point in the history

  9. group similar methods together

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    80cb834 View commit details
    Browse the repository at this point in the history

  10. values are read/write by non main thread (such as RYD). Field must be… 

    … volatile to ensure value changes are seen by other threads. The alternative is to synchronize, but volatile has nearly zero overhead and no thread blocking.
    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    e366a72 View commit details
    Browse the repository at this point in the history

  11. log any crashes

    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    dc9867e View commit details
    Browse the repository at this point in the history

  12. lambda logging messages. No more generating unused debugging logging … 

    …strings.
    @jtenberg
    jtenberg committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7725b0b View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. fixing thread race where multiple concurrent user registration networ… 

    …k calls occur (if the user hits multiple voting buttons quickly in a row)

Moved solve puzzle code into the api class.
Removed now empty Registration and Voting classes.
    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    913e5ad View commit details
    Browse the repository at this point in the history

  2. Automatically log under the class name of calling class. Free extra p… 

    …erformance by not creating the log messages unless logging is actually enabled.
    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    9959fd9 View commit details
    Browse the repository at this point in the history

  3. Automatically log under the class name of calling class. Free extra p… 

    …erformance by not creating the log messages unless logging is actually enabled.
    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    b08e519 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main'

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ce221ab View commit details
    Browse the repository at this point in the history

  5. Merge branch 'revanced:main' into main

    @LisoUseInAIKyrios
    LisoUseInAIKyrios authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    85caabf View commit details
    Browse the repository at this point in the history

  6. using new log methods

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    8633867 View commit details
    Browse the repository at this point in the history

  7. using new log methods

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    00d28a7 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main'

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    51957fb View commit details
    Browse the repository at this point in the history

  9. as per the API, added a client backoff if backend requests it.

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    f1f846c View commit details
    Browse the repository at this point in the history

  10. refactor

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    7cd710e View commit details
    Browse the repository at this point in the history

  11. refactor

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    f50db10 View commit details
    Browse the repository at this point in the history

  12. fixing oversight. added local debug code to verify it works.

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    2830504 View commit details
    Browse the repository at this point in the history

  13. auto indenting code

    @jtenberg
    jtenberg committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d4dc7af View commit details
    Browse the repository at this point in the history

  14. reverting logging changes

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    3f4cf0a View commit details
    Browse the repository at this point in the history

  15. refactor: fix some but not all inconsistencies

    @oSumAtrIX
    oSumAtrIX committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    457e2d6 View commit details
    Browse the repository at this point in the history

  16. Revert "reverting logging changes" 

    This reverts commit 3f4cf0a.
    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    83e102a View commit details
    Browse the repository at this point in the history

  17. Merge remote-tracking branch 'origin/main' 

    # Conflicts:
#	app/src/main/java/app/revanced/integrations/returnyoutubedislike/ReturnYouTubeDislike.java
#	app/src/main/java/app/revanced/integrations/returnyoutubedislike/requests/ReturnYouTubeDislikeApi.java
#	app/src/main/java/app/revanced/integrations/utils/LogHelper.java
    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    7b18b6a View commit details
    Browse the repository at this point in the history

  18. refactor: fix some but not all inconsistencies

    @oSumAtrIX @HundedFifteeTree
    oSumAtrIX authored and HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    1876f95 View commit details
    Browse the repository at this point in the history

  19. typo

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    35fe2d3 View commit details
    Browse the repository at this point in the history

  20. fixing compilation

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    f4acade View commit details
    Browse the repository at this point in the history

  21. inline new logging methods (otherwise the deprecated logging methods … 

    …always shows the utility class as the calling class)
    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    bd879a2 View commit details
    Browse the repository at this point in the history

  22. comments

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    3eac278 View commit details
    Browse the repository at this point in the history

  23. refactor: fix some but not all inconsistencies

    @oSumAtrIX
    oSumAtrIX committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    b915579 View commit details
    Browse the repository at this point in the history

  24. Update app/src/main/java/app/revanced/tiktok/utils/ReVancedUtils.java 

    Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
    @LisoUseInAIKyrios @oSumAtrIX
    LisoUseInAIKyrios and oSumAtrIX authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    54777c2 View commit details
    Browse the repository at this point in the history

  25. Update app/src/main/java/app/revanced/integrations/returnyoutubedisli… 

    …ke/ReturnYouTubeDislike.java

Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
    @LisoUseInAIKyrios @oSumAtrIX
    LisoUseInAIKyrios and oSumAtrIX authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d041812 View commit details
    Browse the repository at this point in the history

  26. merging logging changes

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    c5b19dd View commit details
    Browse the repository at this point in the history

  27. Revert "merging logging changes" 

    This reverts commit c5b19dd, reversing
changes made to d041812.
    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    dd72903 View commit details
    Browse the repository at this point in the history

  28. Revert "Revert "merging logging changes"" 

    This reverts commit dd72903.
    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    c70c02a View commit details
    Browse the repository at this point in the history

  29. comments, cleanup

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    b17a972 View commit details
    Browse the repository at this point in the history

  30. fixing synchronization oversight. must check userId while holding syn… 

    …chronization, otherwise multiple registration calls can still occur.
    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    154b39a View commit details
    Browse the repository at this point in the history

  31. removing new logging

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ef65332 View commit details
    Browse the repository at this point in the history

  32. new logging

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d5685aa View commit details
    Browse the repository at this point in the history

  33. comments

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    1e1a207 View commit details
    Browse the repository at this point in the history

  34. refactor, no functional changes.

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    b4d1892 View commit details
    Browse the repository at this point in the history

  35. Merge branch 'main' into lambdalogging

    @LisoUseInAIKyrios
    LisoUseInAIKyrios authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    3a64434 View commit details
    Browse the repository at this point in the history

  36. Fixing minor logging oversight

    @HundedFifteeTree
    HundedFifteeTree committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    e1d4f37 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. comments

    @jtenberg
    jtenberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    781e583 View commit details
    Browse the repository at this point in the history

  2. comments

    @jtenberg
    jtenberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    70a43be View commit details
    Browse the repository at this point in the history

  3. comments

    @jtenberg
    jtenberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    301a3b5 View commit details
    Browse the repository at this point in the history

  4. comments

    @jtenberg
    jtenberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    e21c43f View commit details
    Browse the repository at this point in the history

  5. comments

    @jtenberg
    jtenberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    9215e43 View commit details
    Browse the repository at this point in the history

  6. Fix for log filtering no longer working if using the usual "logcat | … 

    …grep --line-buffered "revanced"

For now, changing this to the old name casing to preserve compatibility.
    @jtenberg
    jtenberg committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    02fd494 View commit details
    Browse the repository at this point in the history