fix: compare method fingerprint parameter order #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LisoUseInAIKyrios
changed the title
oSumAtrIX
approved these changes
May 30, 2023
revanced-bot
pushed a commit
that referenced
this pull request
May 30, 2023
## [9.0.1-dev.1](v9.0.0...v9.0.1-dev.1) (2023-05-30) ### Bug Fixes * check for two methods parameters orders ([#183](#183)) ([f857a98](f857a98))
oSumAtrIX
pushed a commit
that referenced
this pull request
Jun 7, 2023
BREAKING CHANGE: This requires changes to `MethodFingerprint`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented TODO
Provides stronger matching and gives a slight speed up (around 2-3 seconds improvement when patching YouTube on a laptop), but this also means some existing patches will need updating because the method signature parameters are not the correct order.
edit: all YouTube patches function correctly, also all 'universal' patches work ok as well.