Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Infinity For Reddit): Remove "subscription" page. #290

Closed
3 tasks done
ghost opened this issue Sep 30, 2023 · 6 comments · Fixed by ReVanced/revanced-patches-template#3358
Closed
3 tasks done

Comments

@ghost
Copy link

ghost commented Sep 30, 2023

Application

https://github.com/Docile-Alligator/Infinity-For-Reddit/

Issue

When using the latest version, it redirects me to a page called "subscription".

Screenshot_20230930-152529.png

Patch

Removing the subscription page in infinity for reddit. So that it can be used without any inconveniences!

Motivation

Infinity for reddit is one of my favorite reddit clients. And the beta versions adds new features/design changes!

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@johnconner122
Copy link
Contributor

@johnconner122
Copy link
Contributor

Use v6.1.1, it's latest supported version.

@ghost
Copy link

ghost commented Sep 30, 2023

Thanks!

@Turhvjbufv
Copy link

Not possible due to new guidelines: https://github.com/ReVanced/revanced-patches/blob/dev/CONTRIBUTING.md#%EF%B8%8F-guidelines-for-requesting-or-contributing-patches

Why did they do these new guidelines?, especially the pay one?

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Oct 1, 2023

It's written there

To maintain a high-quality and ethical collection of patches

Though for Infinity, I'm gonna likely make an exception as outlined in there

@oSumAtrIX oSumAtrIX reopened this Oct 1, 2023
@Nero-devbot
Copy link

If it can be applied for infinity then shouldn't Relay for reddit also come under the same ambit?

@oSumAtrIX oSumAtrIX linked a pull request Dec 2, 2023 that will close this issue
1 task
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants