Fix: remove anchor when data-tooltip-id gets changed
#1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Some quick testing shows this works as expected. After @danielbarion also approves it, we'll merge a do a release.
Yep, we've got some open issues with our test specs, don't worry about those. |
gabrieljablonski
approved these changes
Jan 20, 2024
danielbarion
approved these changes
Jan 20, 2024
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
data-tooltip-idgets updated fromAtoBfor the same DOM element, theAstill continues showing the tooltip when it isn't expected. The PR fixes that, nowAwill properly untrack the tooltip whendata-tooltip-idbecomes notAUPD: I see some failed tests. Looks like one test uses the outdated snapshot, the second one seems to be flaky. The same happens in
masteras well