Use jest-matchers for assertions instead of expect #61
Conversation
Add test case to check for matching `queries` prop
- changes proptypes to make query optional and to accept the `queries`
prop
- creates a list of MatchMedia objects for the `queries` prop
- update the `match` property of state to contain an object in the
format of
```
{
[mq name: string]: [matches: bool],
}
```
Use JSX syntax highlighting for JSX in readme
This should ensure backwards compatibility
Previously, mediaQueryList could have multiple types. Now, it's always an array.
Allow for specifying defaultMatches
`mediaQueryList` was not actually a `MediaQueryList`, so name it appropriately.
`mm` _is_ an acutal `MediaQueryList`, so name it appropriately.
Multiple Queries
Update queries test
|
Thanks, @skovhus! I have a LOT of code that uses |
|
I kept the running in a browser. Let me know if you just want to run these tests in node and with JS Dom. That will remove a lot of karma boilerplate. But might also lower your confidence that this code works in IE. |
package.json
Outdated
| @@ -38,7 +38,7 @@ | |||
| "eslint-plugin-react": "^6.0.0", | |||
| "gzip-size": "^3.0.0", | |||
| "in-publish": "^2.0.0", | |||
| "jest-matchers": "^19.0.0", | |||
| "jest-matchers": "19.2.0-alpha.993e64af", | |||
Use prop-types package
modules/__tests__/Media-test.js
Outdated
| @@ -133,7 +133,7 @@ describe('A <Media>', () => { | |||
| ) | |||
|
|
|||
| render(element, node, () => { | |||
| expect(node.firstChild.innerHTML).toNotMatch(/hello/) | |||
| expect(node.firstChild.innerHTML).not.toBeDefined() | |||
There was a problem hiding this comment.
This is wrong, should be .not.toMatch(/hello/). Or is it on purpose?
There was a problem hiding this comment.
Saw your comment.
toMatch can also be on objects, so cannot be translated 1:1 with Jest toMatch... See mjackson/expect#tomatch (maybe toMatchObject?)
There was a problem hiding this comment.
Yeah, this looks funky. Thanks for noticing it. Will have a look... I need to get back into the code I was doing in April. 🙀
Unchecked this point in my TODO:
skovhus/jest-codemods#39
There was a problem hiding this comment.
@SimenB If I remember correctly this might be a manual change I did, as node.firstChild.innerHTML is not defined AND Jest .not.toMatch(/hello/) fails in that case. Not sure if that should be considered a bug in Jest.
There was a problem hiding this comment.
Error: expect(string)[.not].toMatch(expected)
string value must be a string.
Received: undefined
There was a problem hiding this comment.
Interesting... Not sure if it's a bug or not.
You can do toBeUndefined() instead of .not.toBeDefined(), btw.
Green build though, woo!
There was a problem hiding this comment.
Yes, been waiting some months to see that pretty green ✅
Yay!
There was a problem hiding this comment.
You always change my matchers into something nicer. :)
|
Thanks for the PR, @skovhus. I chose to convert everything to using Jest in 20fcf76, so I think we can close this. We were able to ditch a lot of Karma boilerplate, as well as a flaky BrowserStack integration, which was a huge plus. I'm just stubbing out the |
|
@mjackson sounds good :) |
Currently expect@1.x is being integrated into Jest (see more background in jestjs/jest#1679).
In jest-codemods I'm working on a codemod to automate the process of going from mjackson/expect to jest-matchers (if running in a browser) or plain Jest (if running in node). 🤖
I've tested the codemod on this project and everything should still work.
Let me know what you think.
Blocked: currently fails in older browsers 💣
Seems like jest-matchers have untranspiled code
SyntaxError: Unexpected keyword 'const'. Const declarations are not supported in strict mode..Will look into a solution for this.