Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-default API 28 images #117

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

linl33
Copy link
Contributor

@linl33 linl33 commented Jan 5, 2021

google_apis and google_apis_playstore API 28 system images require the android-sdk-arm-dbt-license license file, like API 30 system images. This patch updates the check for android-sdk-arm-dbt-license to include API 28 system images. The workflow configuration has also been updated to test API 28.

@ychescale9
Copy link
Member

Thanks! Can you run npm run build locally and push the compiled js files?

@linl33
Copy link
Contributor Author

linl33 commented Jan 5, 2021

npm run build only produced lib/sdk-installer.js, which is already included. Should there be something else?

@ychescale9
Copy link
Member

Sorry I missed that! I'll do a new release now. Thanks for contributing!

@ychescale9 ychescale9 merged commit 434e949 into ReactiveCircus:main Jan 5, 2021
@linl33 linl33 deleted the fix-google-28 branch January 5, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants