Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to modify the number of cores #130

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

AfzalivE
Copy link
Contributor

@AfzalivE AfzalivE commented Mar 2, 2021

As discussed in #126, the emulator being set up by avdmanager in the new command-line tools only uses 1 core, which affects the stability of the emulator negatively sometimes.

In our experience, 2 cores seem to be pretty solid with no (or almost no) System UI ANR dialogs being shown on boot.

Appending a new line with a duplicate hw.cpu.ncore overrides other lines defining the same property before it.

Please let me know if you'd like me to add this option in workflow.yml file as well so that the tests include this option as well. Wasn't sure about updating that.

@ychescale9
Copy link
Member

Thanks!

Please let me know if you'd like me to add this option in workflow.yml file as well so that the tests include this option as well. Wasn't sure about updating that.

Yes let's do this.

I'm also keen to add a default value (2) for core so we don't need to ask users to opt in to see if this improves stability (unless they pin the action to a specific version). What do you think?

@AfzalivE
Copy link
Contributor Author

AfzalivE commented Mar 2, 2021

I'm also keen to add a default value (2) for core so we don't need to ask users to opt in to see if this improves stability (unless they pin the action to a specific version). What do you think?

I think this would be good and doesn't severely impact Gradle compilation while the emulator is running, in my experience. Updated.

Copy link
Member

@ychescale9 ychescale9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I’ll try to do a release this weekend.

@ychescale9 ychescale9 merged commit 27a0759 into ReactiveCircus:main Mar 2, 2021
@AfzalivE AfzalivE deleted the add-num-cores-options branch March 2, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants