Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveCocoa 2.0 #618

Merged
merged 779 commits into from
Aug 21, 2013
Merged

ReactiveCocoa 2.0 #618

merged 779 commits into from
Aug 21, 2013

Conversation

jspahrsummers
Copy link
Member

See the CHANGELOG for a list of all major and breaking changes, and information on how to update your project.

Performance improvements and critical fixes should continue to be applied to RAC 1.x until this branch is merged. After merging, 1.x versions will no longer be actively developed.

✨ Many thanks to everyone who's been helping! ✨

@jspahrsummers
Copy link
Member Author

@ReactiveCocoa/reactivecocoa Do you guys think we should create some sort of migration guide for RAC 1.x -> 2.0? I personally think our deprecation messages and compiler errors will be good enough, but I'm receptive to the idea.

@mdiep
Copy link
Contributor

mdiep commented Jul 17, 2013

I think a migration guide would be helpful. Even if it was just a list of deprecations, it's helpful to know what's changed if you're trying to decide when to upgrade.

In my mind, it's the same material but it's presented at a different time for a different reason.

@jspahrsummers
Copy link
Member Author

@mdiep Well, this PR is meant to be the "what's changed" listing. A migration guide would be more about walking you through exactly how to update the code.

@Coneko
Copy link
Member

Coneko commented Jul 18, 2013

I think the deprecation messages will be enough too, but I'm afraid we're biased because we've been exposed to the changes gradually. Users migrating from 1.x would have to deal with all the changes at the same time: it might be overwhelming and they might give up on upgrading and stick to 1.x, which would be really bad.

@kastiglione
Copy link
Member

Would the migration guide need to give coverage to each deprecation and each new method? Or just those we single out? Either way, I'd be happy to help write pieces.

My hope is that there is a natural relationship between the amount of work needed to upgrade a codebase to RAC 2.0, and the comfort that the developer will have in making the changes. A developer who has only got their feet wet, will have fewer changes to make, whereas a developer that has used RAC more heavily will hopefully have a higher comfort level with handling the changes.

Finally, either way, the various 2.0 announcements can include reminders to create Issues for any problems they run into.

@jspahrsummers
Copy link
Member Author

Discussion on the above moved to #679.

jspahrsummers added a commit that referenced this pull request Jul 18, 2013
@Coneko
Copy link
Member

Coneko commented Aug 20, 2013

👍 for me.

joshaber and others added 7 commits August 20, 2013 08:58
…tion

Fix RACCommand.enabled only completing after the input signal does
This means not using -autoconnect, and aligns more closely to the
behavior of our other -replay… operators.
…nges

-replayLazily behavior changes, -autoconnect refactoring
@jspahrsummers
Copy link
Member Author

IT'S HAPPENING

jspahrsummers added a commit that referenced this pull request Aug 21, 2013
@jspahrsummers jspahrsummers merged commit 80408f6 into master Aug 21, 2013
@jspahrsummers jspahrsummers deleted the 2.0-development branch August 21, 2013 00:36
@jonsterling
Copy link
Contributor

Really nice work guys! 🍷

@tonyarnold
Copy link
Contributor

+1 — congratulations to all of you on a great update! 🐶

@jspahrsummers
Copy link
Member Author

Thanks again to everyone who helped! 🍻

@brow
Copy link
Contributor

brow commented Aug 21, 2013

🎊

@dannygreg
Copy link
Member

@joshaber
Copy link
Member

💥💥💥

@kastiglione
Copy link
Member

📶

@jwilling
Copy link
Contributor

❤️

@travisjeffery
Copy link

jeremiah-johnson-nod-smaller

@robb
Copy link
Member

robb commented Aug 21, 2013

🎉

@kkazuo
Copy link
Contributor

kkazuo commented Aug 21, 2013

Congratulations!!! 🌟

@jspahrsummers
Copy link
Member Author

I've tagged the official v2.0 release, since the RCs have seemed very good so far. Future improvements can come in minor or patch releases.

@ashfurrow
Copy link
Member

🍻

@tonyarnold
Copy link
Contributor

🎆

@kkazuo
Copy link
Contributor

kkazuo commented Sep 15, 2013

🚀

@kastiglione
Copy link
Member

🎉 🎊

@kastiglione
Copy link
Member

@ashfurrow does that mean you're buying the first round?

@apparentsoft
Copy link

👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.