Xcode9 prototype issue fix #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
xcode9-prototype-issue-fix
branch
from
a33d25a to
837f82e
Compare
|
@mdiep Since it could be source breaking, should we bump to 4.0? 🤔 |
andersio
force-pushed
the
xcode9-prototype-issue-fix
branch
from
837f82e to
d7263d0
Compare
mdiep
approved these changes
Dec 23, 2017
|
I don't think this is source breaking. The only change that could be is the |
|
I have changed the signature of |
|
Ah, I missed that bit. Still, I think that qualifies as a bug fix. Objective-C should be more tolerant of a change like that. |
This was referenced Dec 30, 2017
stuartofmine
pushed a commit
to stuartofmine/ReactiveObjC_2023
that referenced
this pull request
Oct 18, 2023
…ype-issue-fix Xcode9 prototype issue fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #115.
Preceded by #119 and #122.