Updated Quick and Nimble (Swift 4.2+ support) #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakovi89
changed the title
mdiep
approved these changes
Apr 1, 2019
mdiep
requested changes
Apr 1, 2019
| @@ -2823,7 +2824,7 @@ | |||
| CURRENT_PROJECT_VERSION = 1; | |||
| ENABLE_TESTABILITY = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.9; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.10; | |||
There was a problem hiding this comment.
Can you change the deployment target of the test target only? The actual framework should be able to stay deployable to 10.9.
mdiep
approved these changes
Apr 1, 2019
|
Thanks a lot @mdiep, I'll do another PR for the ObjcBridge in a moment |
|
Looks like some of the tests still need a macOS 10.10 deployment target. |
|
You're right - |
mdiep
approved these changes
Apr 1, 2019
|
Thanks! |
1 task
stuartofmine
pushed a commit
to stuartofmine/ReactiveObjC_2023
that referenced
this pull request
Oct 18, 2023
Updated Quick and Nimble (Swift 4.2+ support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Quick and Nimble for swift 4.2 support