Redeclare operations built on RACStream primitives with more precise type information (continued) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type information (continued) Redeclares operations built on RACStream primitives with more precise type information. This continues the work from ReactiveCocoa#37 by adding the RACStream operators RACSequence, and updating RACStream methods to return `__kindof RACStream`. This will allow lightweight generics to be added to `RACSequence` quite easily (following the same pattern as RACSignal), if desired. I have verified that this fixes issue ReactiveCocoa#40 by testing out the code in the issue. This is fixed by giving less precise type information to the `RACSteam` operator return values (`__kindof RACStream *`, rather than `instancetype`, as before), so that the compiler references the `RACSignal` version.
Merged
mdiep
approved these changes
Nov 20, 2016
byohay
pushed a commit
to byohay/ReactiveObjC
that referenced
this pull request
Dec 14, 2021
RACSignal+Operations: add -[RACSignal retry:when:]..
stuartofmine
pushed a commit
to stuartofmine/ReactiveObjC_2023
that referenced
this pull request
Oct 18, 2023
Redeclare operations built on RACStream primitives with more precise type information (continued)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redeclares operations built on RACStream primitives with more precise type information. This continues the work from #37 by adding the RACStream operators RACSequence, and updating RACStream methods to return
__kindof RACStream.This will allow lightweight generics to be added to
RACSequencequite easily (following the same pattern as RACSignal), if desired.I have verified that this fixes issue #40 by testing out the code in the issue. This is fixed by giving less precise type information to the
RACSteamoperator return values (__kindof RACStream *, rather thaninstancetype, as before), so that the compiler references theRACSignalversion.Additionally, I have verified that our large ReactiveCocoa 2.x codebase can be successfully migrated with these changes without any other issues like #40.