-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More type annotations #81
More type annotations #81
Conversation
This means that `[RACSignal<NSString *> empty]` actually returns a signal of NSString objects (even if it won't ever emit any values).
As an example, this allows us to call `[[signal publish] autoconnect]` and retain the generic type of the original signal.
As an example, this allows us to call `[[signal publish] autoconnect]` and retain the generic type of the original signal.
…C into more-type-annotations
This is great! Aren't some of these classes private to the implementation to ReactiveObjC? E.g. Re: Re: |
Yes, true, for Meanwhile, it seems the Travis CI build failed, although everything was hunky dory when running the tests locally. I'll have a look at that. |
That seems reasonable re: the internal types—it doesn't add any overhead to consumers. |
All right, so I'll keep it as it is, then. As for the failing Travis CI build, it seems to be a failure in three tests related to intervals. I don't see how that could possibly be caused by these type changes, and, moreover, the same tests pass locally. Is it possible that the tests themselves are fickle, or that there are problems with the CI environment? |
@erichoracek Possible to merge? |
Includes ReactiveCocoa#75, ReactiveCocoa#80, ReactiveCocoa#81, ReactiveCocoa#82, ReactiveCocoa#83, ReactiveCocoa#85, ReactiveCocoa#87, and ReactiveCocoa#88. As far as I can tell, this should have no breaking changes.
Includes ReactiveCocoa#75, ReactiveCocoa#80, ReactiveCocoa#81, ReactiveCocoa#82, ReactiveCocoa#83, ReactiveCocoa#85, ReactiveCocoa#87, and ReactiveCocoa#88. While this has no breaking changes in Obj-C, it will likely introduce breaking changes in Swift.
More type annotations
Includes ReactiveCocoa#75, ReactiveCocoa#80, ReactiveCocoa#81, ReactiveCocoa#82, ReactiveCocoa#83, ReactiveCocoa#85, ReactiveCocoa#87, and ReactiveCocoa#88. While this has no breaking changes in Obj-C, it will likely introduce breaking changes in Swift.
This pull request adds generics to
RACMulticastConnection
,RACBehaviorSubject
and type annotations toRACSignal
's+empty
and+return
methods.It seems to me that it'd also make sense to add generics to
RACChannelTerminal
,RACChannel
andRACSubject
. Thoughts on that?