Skip to content

Commit

Permalink
Replace the use of ended signal with observeEnded as appropriate.
Browse files Browse the repository at this point in the history
  • Loading branch information
andersio committed Feb 17, 2017
1 parent c2e55ce commit 3081538
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Sources/Action.swift
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public final class Action<Input, Output, Error: Swift.Error> {
lifetime = Lifetime(deinitToken)

// Retain the `property` for the created `Action`.
lifetime.ended.observeCompleted { _ = property }
lifetime.observeEnded { _ = property }

executeClosure = { state, input in execute(state as! State.Value, input) }

Expand Down
2 changes: 1 addition & 1 deletion Tests/ReactiveSwiftTests/LifetimeSpec.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Quick
import Nimble
@testable import ReactiveSwift
import ReactiveSwift
import Result

final class LifetimeSpec: QuickSpec {
Expand Down
2 changes: 1 addition & 1 deletion Tests/ReactiveSwiftTests/PropertySpec.swift
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ class PropertySpec: QuickSpec {
var property = Optional(MutableProperty<Int>(1))

var isEnded = false
property!.lifetime.ended.observeCompleted {
property!.lifetime.observeEnded {
isEnded = true
}

Expand Down
2 changes: 1 addition & 1 deletion Tests/ReactiveSwiftTests/SignalProducerSpec.swift
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@ class SignalProducerSpec: QuickSpec {

it("doesn't extend the lifetime of the throttle property") {
var completed = false
shouldThrottle.lifetime.ended.observeCompleted { completed = true }
shouldThrottle.lifetime.observeEnded { completed = true }

observer.send(value: 1)
shouldThrottle = nil
Expand Down
2 changes: 1 addition & 1 deletion Tests/ReactiveSwiftTests/SignalSpec.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1713,7 +1713,7 @@ class SignalSpec: QuickSpec {

it("doesn't extend the lifetime of the throttle property") {
var completed = false
shouldThrottle.lifetime.ended.observeCompleted { completed = true }
shouldThrottle.lifetime.observeEnded { completed = true }

observer.send(value: 1)
shouldThrottle = nil
Expand Down

0 comments on commit 3081538

Please sign in to comment.