-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 5.0 and Result in Standard Library #696
Comments
The accepted proposal is: public enum Result<Success, Failure: Error> {
case success(Success)
case failure(Failure)
} 💯 we should use this.
|
@mdiep the accepted signature 1-by-1 to |
The tricky bit is |
|
Argh! That’s brilliant. Missed that part from the SE proposal. |
Result already updated for Swift 5.0, see antitypical/Result#278 |
Assuming antitypical/Result would just be augmenting the stdlib RAS depends on |
I think it can just be extensions in ReactiveSwift without Result dependency. |
Yes, I think so. 👍 |
Oh I missed this. I started the process: #702. I'm excited to make ReactiveSwift dependency-free :) |
@NachoSoto great to see pilots here :) |
@larryonoff I think we could close this issue now that #702 |
👍🏻 |
I think it's time to start preparation for the new features of Swift 5.0, i.e. Result that has been recently accepted to the standard library, see
https://github.com/apple/swift-evolution/blob/master/proposals/0235-add-result.md.
The issue that I see that migration to the Swift.Result is a breaking change since different signatures.
https://github.com/apple/swift-evolution/blob/master/proposals/0235-add-result.md
when https://github.com/antitypical/Result
I totally respect to https://github.com/antitypical/Result, but I think that it's better using Standard Library.
Any community thought about?
The text was updated successfully, but these errors were encountered: