Removing Result in favor of Swift.Result #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesyo
reviewed
Jan 15, 2019
|
Ref: #696 |
|
@mdiep Do we not want to keep |
|
That's not a bad idea. Maybe a deprecated typealias? That would ease migration. |
NachoSoto
force-pushed
the
remove-result
branch
from
d4dafd7
to
76dcaed
Compare
NachoSoto
force-pushed
the
remove-result
branch
from
76dcaed
to
5f232eb
Compare
2 tasks
|
This is 90% I think. If anyone wants to finish this please go ahead 🙏 |
Done! |
mdiep
changed the title
|
I think this is ready, but I'd like to get a 5.0.1 release in first to fix the warnings in Xcode 10.2. |
andersio
requested changes
Mar 31, 2019
| @@ -22,16 +21,16 @@ internal extension SignalProducer { | |||
| /// Halts if an error is emitted in the receiver signal. | |||
| /// This is useful in tests to be able to just use `startWithNext` | |||
| /// in cases where we know that an error won't be emitted. | |||
| func assumeNoErrors() -> SignalProducer<Value, NoError> { | |||
| return self.lift { $0.assumeNoErrors() } | |||
| func assumeNevers() -> SignalProducer<Value, Never> { | |||
There was a problem hiding this comment.
This should not be renamed since the real meaning is now lost.
There was a problem hiding this comment.
Agreed. The "no error" part of this method name was beyond the NoError type.
andersio
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got out of my cockpit for a day to do some coding and experiment with this.
I understand we'd be dropping support for anything prior to Swift 5.0, so this is kinda just a proof of concept until the next major version?
Code is almost compiling, I'll try to finish it tomorrow.
Checklist
QuickandNimble.Package.resolved(not sure how)NoError(withNeverfixit)