-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Result in favor of Swift.Result #702
Conversation
Ref: #696 |
@mdiep Do we not want to keep |
That's not a bad idea. Maybe a deprecated typealias? That would ease migration. |
d4dafd7
to
76dcaed
Compare
76dcaed
to
5f232eb
Compare
This is 90% I think. If anyone wants to finish this please go ahead 🙏 |
Done! |
I think this is ready, but I'd like to get a 5.0.1 release in first to fix the warnings in Xcode 10.2. |
@@ -22,16 +21,16 @@ internal extension SignalProducer { | |||
/// Halts if an error is emitted in the receiver signal. | |||
/// This is useful in tests to be able to just use `startWithNext` | |||
/// in cases where we know that an error won't be emitted. | |||
func assumeNoErrors() -> SignalProducer<Value, NoError> { | |||
return self.lift { $0.assumeNoErrors() } | |||
func assumeNevers() -> SignalProducer<Value, Never> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be renamed since the real meaning is now lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. The "no error" part of this method name was beyond the NoError
type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. 👍
I got out of my cockpit for a day to do some coding and experiment with this.
I understand we'd be dropping support for anything prior to Swift 5.0, so this is kinda just a proof of concept until the next major version?
Code is almost compiling, I'll try to finish it tomorrow.
Checklist
Quick
andNimble
.Package.resolved
(not sure how)NoError
(withNever
fixit)