-
Notifications
You must be signed in to change notification settings - Fork 184
Conversation
|
Thanks for the PR. I'll have a look at it tomorrow. |
I think |
I've been adding some changes on top of this PR, which can be found here: https://github.com/Thomvis/BrightFutures/tree/kimdv-kimdv/swift-5. @mathebox I agree with your suggestion to use I think |
…removed in the future.
Rebased on solved conflicts |
Thanks! A few comments:
|
This reverts commit eb54ac7.
Thanks for your work! I think this could be released as a first beta of 8.0. There's one thing I'm trying to figure out: can we make this work without adding new public API to the Result type. Users of BrightFutures will now, for example, all have a |
So you think we should make I don't think it is possible because it is used on other public API's |
Since ReactiveCocoa/ReactiveSwift#702 is doing something very similar to what we're doing, I believe we're good and I'll move forward with the release. |
Thanks again for your work. 8.0.0 has been released! 🚀 I've invited you as a collaborator if you wish to contribute in the future. |
Thanks a lot @Thomvis ! I have accepted 🚀 |
Hi!
I started porting to Swift 5 with the new Swift Result and it resolves #205
Had some problems with the generics in Swift, so needed to copy the some classes from the old Result framework.
It would be nice if we somehow can remove those.
Thanks! 🚀