Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.6.0 requires Swift 5.3 and therefore Xcode 12.x #822

Closed
mluisbrown opened this issue Mar 16, 2021 · 0 comments · Fixed by #823
Closed

Release 6.6.0 requires Swift 5.3 and therefore Xcode 12.x #822

mluisbrown opened this issue Mar 16, 2021 · 0 comments · Fixed by #823

Comments

@mluisbrown
Copy link
Contributor

mluisbrown commented Mar 16, 2021

The code added (by me 🙈) in #810 requires Swift 5.3 because of SE-267.

This is because we are using a where clause without the function itself being explicitly generic (even though it is in a generic context):

public static func interval(
_ interval: DispatchTimeInterval,
on scheduler: DateScheduler
) -> SignalProducer where Value == Int {

Unsure about whether this is an issue or not, but the README has the Swift 5.1 badge, so I guess it should be fixed. It's also an easy fix. Might be worth considering also using Xcode 11.7 in CI, which would have caught this problem.

mluisbrown added a commit to mluisbrown/ReactiveSwift that referenced this issue Mar 16, 2021
Make the code compatible with Swift 5.1 and 5.2 again. Resolves ReactiveCocoa#822
andersio pushed a commit that referenced this issue Apr 23, 2021
* Fix requirement for Swift 5.3

Make the code compatible with Swift 5.1 and 5.2 again. Resolves #822

* Added entry to Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant