Rename times to repeat.
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
reviewed
Nov 26, 2016
| @@ -279,6 +288,18 @@ extension SignalProducerProtocol { | |||
|
|
|||
| @available(*, unavailable, message:"This SignalProducer may emit errors which must be handled explicitly, or observed using `startWithResult(_:)`.") | |||
| public func startWithNext(_ next: (Value) -> Void) -> Disposable { fatalError() } | |||
|
|
|||
| @available(*, unavailable, renamed:"repeat(_:)") | |||
NachoSoto
reviewed
Nov 26, 2016
| @@ -207,6 +207,15 @@ extension SignalProtocol { | |||
|
|
|||
| @available(*, unavailable, message: "This Signal may emit errors which must be handled explicitly, or observed using `observeResult(_:)`") | |||
| public func observeNext(_ next: (Value) -> Void) -> Disposable? { fatalError() } | |||
|
|
|||
| @available(*, unavailable, renamed:"catch(_:)") | |||
| public func flatMapError<F>(_ handler: @escaping (Error) -> SignalProducer<Value, F>) -> Signal<Value, F> { fatalError() } | |||
There was a problem hiding this comment.
flatMapError is far more descriptive. catch is a well known word but it doesn't carry the extra information that this does, which draws a parallel with flatMap.
NachoSoto
reviewed
Nov 26, 2016
| public func attempt(_ operation: @escaping (Value) -> Result<(), Error>) -> Signal<Value, Error> { fatalError() } | ||
|
|
||
| @available(*, unavailable, renamed:"tryMap(_:)") | ||
| public func attemptMap<U>(_ operation: @escaping (Value) -> Result<U, Error>) -> Signal<U, Error> { fatalError() } |
There was a problem hiding this comment.
These names are meant to match the Result counterparts.
NachoSoto
requested changes
Nov 26, 2016
andersio
changed the title
catch, try and repeat.times to repeat.
ikesyo
requested changes
Nov 28, 2016
| @@ -1,5 +1,5 @@ | |||
| import Foundation | |||
| import enum Result.NoError | |||
| import Result | |||
mdiep
approved these changes
Nov 28, 2016
ikesyo
approved these changes
Nov 28, 2016
NachoSoto
approved these changes
Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #118