Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AnyError for URLSession.reactive.data(with:) #133

Merged
merged 3 commits into from
Dec 2, 2016
Merged

Use AnyError for URLSession.reactive.data(with:) #133

merged 3 commits into from
Dec 2, 2016

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Nov 29, 2016

@ikesyo ikesyo added this to the 1.0 milestone Nov 29, 2016
sharplet
sharplet approved these changes Nov 29, 2016
View reviewed changes
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Two thumbs up from me 👍

@sharplet
Copy link
Contributor

Is there a way we can provide a deprecation warning for this change? I'm unsure what the impact of this change would be on code expecting NSError.

@ikesyo
Copy link
Member Author

ikesyo commented Nov 29, 2016

Is there a way we can provide a deprecation warning for this change?

Something like this? 😉

2016-11-29 14 49 30

@sharplet
Copy link
Contributor

Looks good

@mdiep
Copy link
Contributor

mdiep commented Nov 29, 2016

Why isn't NSError correct here? Isn't that what the Foundation API will have returned?

@sharplet
Copy link
Contributor

It's bridged as Error, so I think it makes us a better Swift 3 citizen to preserve that as accurately as possible.

@mdiep mdiep merged commit 02e7cf6 into master Dec 2, 2016
@mdiep mdiep deleted the anyerror branch December 2, 2016 13:05
@ikesyo ikesyo mentioned this pull request Dec 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdiep mdiep mdiep approved these changes

@sharplet sharplet sharplet approved these changes

Assignees
No one assigned
Labels
proposal
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikesyo @sharplet @mdiep