Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename innerDisposable to inner. #164

Merged
merged 1 commit into from
Dec 18, 2016
Merged

Rename innerDisposable to inner. #164

merged 1 commit into from
Dec 18, 2016

Conversation

andersio
Copy link
Member

SerialDisposable.innerDisposable -> SerialDisposable.current.
ScopedDisposable.innerDisposable -> ScopedDisposable.wrapped.

@sharplet
Copy link
Contributor

Works for me 👍

@mdiep
Copy link
Contributor

mdiep commented Dec 18, 2016

I kinda like these both using the same name. They're really the same thing; it's just that one is mutable and the other immutable.

Personally, I think inner or disposable makes the most sense. Wrapped makes more sense to me as a generic type than wrapped does as an accessor.

@andersio
Copy link
Member Author

@mdiep Reverted to inner.

@andersio andersio changed the title Rename innerDisposable to current and wrapped. Rename innerDisposable to inner. Dec 18, 2016
@mdiep mdiep merged commit 4350e18 into master Dec 18, 2016
@mdiep mdiep deleted the inner-disposable branch December 18, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants