Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flatMap(_:transform:) to flatMap(_:_:). #339

Merged
merged 2 commits into from
May 5, 2017

Conversation

andersio
Copy link
Member

@andersio andersio commented Apr 20, 2017

While the API guidelines says all argument labels should be named unless otherwise specified, the transforms of FP-borrowed operators usually do not have a label given the "terms of art" treatment. So the PR proposes to strip the label from flatMap.

@mdiep
Copy link
Contributor

mdiep commented Apr 25, 2017

Something like return self.flatMap(.merge, SignalProducer.init) seems a little weird to me, but I think I'm 👍 on this. 😕

On the one hand, Swift's flatMap has an unnamed argument (and so does our flatMapError). On the other hand, this flatMap has 2 arguments.

Since I don't think this is obviously the better option, I'd like to give @ReactiveCocoa/reactiveswift a chance to speak up in case anyone has an objection.

@mdiep
Copy link
Contributor

mdiep commented May 5, 2017

No objects, so I think this is good to go. Want to fix up the conflicts?

I'm thinking that we should really make our deprecations file based on the version. So Deprecations+Removals-1.swift, Deprecations+Removals-2.swift, etc.

@andersio andersio modified the milestone: 2.0 May 5, 2017
@andersio
Copy link
Member Author

andersio commented May 5, 2017

Rebased.

@mdiep mdiep merged commit 6255c24 into master May 5, 2017
@mdiep mdiep deleted the drop-flatmap-transform-label branch May 5, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants