Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename promoteErrors to promoteError. #408

Merged
merged 2 commits into from
May 28, 2017
Merged

Rename promoteErrors to promoteError. #408

merged 2 commits into from
May 28, 2017

Conversation

andersio
Copy link
Member

@andersio andersio commented May 25, 2017 •
edited

Every Signal has only one error. Should it be promote(_:) though?

@brow
Copy link
Contributor

brow commented May 25, 2017 •
edited

Should it be promote(_:) though?

SignalProducer<Never, FooError> is sometimes useful, so maybe it will eventually be desirable for ReactiveSwift to define a promoteValues along with promoteError? I've done that in my project.

@andersio
Copy link
Member Author

@brow Yeah. @ikesyo has also talked about it. Feel free to start a PR if you want. 😸

@andersio andersio mentioned this pull request May 26, 2017
Merged
@mdiep mdiep merged commit 5d5e983 into master May 28, 2017
@mdiep mdiep deleted the promoteerror branch May 28, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdiep mdiep mdiep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersio @brow @mdiep