Prefer generic parameters to Scheduler existentials.
#410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
changed the title
Scheduler existentials.Scheduler existentials.
|
What's the benefit of this change? |
|
No apparent benefit for now. Ideally this would allow the compiler to "see through" the interface and perform specialisation. But it doesn't because we do not have cross-module optimisation (yet). Auto-promotion of existentials to generic parameters is one of the ABI stability items, btw. |
|
Given that it makes the method signatures a little harder to read, I feel like I'm 👎 on this for now |
I agree. Let's do this when/if there's some benefit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.