s/(ActionDisposable|SimpleDisposable)/AnyDisposable/g #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
use-anydisposable
branch
2 times, most recently
from
58ffb12
to
aaf2c30
Compare
andersio
changed the title
andersio
force-pushed
the
use-anydisposable
branch
4 times, most recently
from
9c6e4ec
to
23ae621
Compare
andersio
changed the title
andersio
force-pushed
the
use-anydisposable
branch
3 times, most recently
from
5c49da0
to
aaaa1b6
Compare
mdiep
requested changes
May 28, 2017
Sources/Disposable.swift
Outdated
| /// work. | ||
| public final class SimpleDisposable: Disposable { | ||
| private var state = UnsafeAtomicState(DisposableState.active) | ||
| private let base: Backing |
There was a problem hiding this comment.
I don't care for this implementation. I find this "multiple implementation via a backing enum" approach to be difficult to reason about.
If we kept SimpleDisposable and ActionDisposable, but made them private and added inits that exposed the functionality publicly, then I think I'd be onboard.
There was a problem hiding this comment.
True. That does sound better.
andersio
force-pushed
the
use-anydisposable
branch
from
aaaa1b6
to
69c8db3
Compare
mdiep
approved these changes
May 28, 2017
mdiep
approved these changes
May 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fold
ActionDisposableandSimpleDisposableintoAnyDisposable.Move
+=operator to the concrete types.