-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4 #422
Conversation
- before_install: | ||
- eval "$(curl -sL https://gist.githubusercontent.com/kylef/5c0475ff02b7c7671d2a/raw/9f442512a46d7a2af7b850d65a7e9bd31edfb09b/swiftenv-install.sh)" | ||
script: | ||
- swift build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nimble doesn't build with Swift 4, so this only builds for now. 😞
Could you add a job for the Swift 3 compatibility mode? |
(Unrelated to the PR) The lost of implicit 1-tuple destructing makes me wonder if we need to introduce sth like |
I'm not sure how to do that, so I'd love to leave it for a separate PR. |
interrupted: log(.interrupted), | ||
terminated: log(.terminated), | ||
disposed: log(.disposed), | ||
completed: log(.completed) as ((()) -> Void)?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh
This gets
master
building with the Swift 4 snapshots.Changes fall into 2 categories: