Swift 4 #422
Merged
Swift 4 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
commented
Jun 1, 2017
| - before_install: | ||
| - eval "$(curl -sL https://gist.githubusercontent.com/kylef/5c0475ff02b7c7671d2a/raw/9f442512a46d7a2af7b850d65a7e9bd31edfb09b/swiftenv-install.sh)" | ||
| script: | ||
| - swift build |
There was a problem hiding this comment.
Nimble doesn't build with Swift 4, so this only builds for now. 😞
|
Could you add a job for the Swift 3 compatibility mode? |
|
(Unrelated to the PR) The lost of implicit 1-tuple destructing makes me wonder if we need to introduce sth like |
I'm not sure how to do that, so I'd love to leave it for a separate PR. |
NachoSoto
reviewed
Jun 5, 2017
| interrupted: log(.interrupted), | ||
| terminated: log(.terminated), | ||
| disposed: log(.disposed), | ||
| completed: log(.completed) as ((()) -> Void)?, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets
masterbuilding with the Swift 4 snapshots.Changes fall into 2 categories: