Overload map() to support key paths #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
approved these changes
Jun 7, 2017
NachoSoto
approved these changes
Jun 7, 2017
| #if swift(>=3.2) | ||
| it("should work with key paths") { | ||
| let property = MutableProperty("foo") | ||
| let mappedProperty = property.map(\.count) |
mdiep
approved these changes
Jun 7, 2017
|
KeyPaths are the best thing ever. 💖 |
|
(Irrelevant to this PR) I hope the Swift gurus manage to get key path decomposition into 4.0. With it we can make 🙀🙀🙀🙀🙀🙀🙀 |
|
I don't think these tests are actually going to run on CI right now. But since we've updated Nimble, we should be able to run |
|
Happy to wait for #436 and rebase. |
|
or #437 😂 |
|
Ready to go 👍 |
mdiep
approved these changes
Jun 9, 2017
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to use key paths with
flatMap()too, but this is a start.