Nesting the result and the output type into ValidatingProperty. #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
nesting-validating-prop
branch
from
8bfb00d
to
e9b8e58
Compare
|
Note that |
sharplet
reviewed
Jun 10, 2017
| case valid | ||
| /// Represents a decision of a validator of a validating property made on a | ||
| /// proposed value. | ||
| public enum Decision { |
There was a problem hiding this comment.
How would you feel about Status?
There was a problem hiding this comment.
It is a result of an aggressive action, while status is passive state of a matter. Output is still a choice, but it felt too generic for me. We can also revert to ValidatorOutput.
mdiep
approved these changes
Jun 20, 2017
|
I don't love |
mdiep
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist