Send interrupted when an input observer deinitializes.
#463
Conversation
andersio
changed the title
interrupted when an input observer deinitializes.interrupted when an input observer deinitializes.
| // Since `Signal` would ensure that only one terminal event would ever be | ||
| // sent for any given `Signal`, we do not need to assert any condition | ||
| // here. | ||
| action(.interrupted) |
There was a problem hiding this comment.
Would it mess up anything if we always sent interrupted on deinit? I'm wondering if that'd be a better option.
There was a problem hiding this comment.
It would mess up the promise of no event being sent after any terminal event, unless we track termimation per observer. In general attached observers do not need auto interruption.
Detaching an observer could use an interrupted event though.
There was a problem hiding this comment.
The promise is only at the Signal level though. That wouldn't be broken.
There was a problem hiding this comment.
IMO Observer is part of the Signal contract.
It also breaks the useful guarantee of terminal events being sent at most once, that would potentially break things e.g. cleaning up resource twice, triggering cancellation code after successful completion.
Implements #461.
Checklist