Add retry(upTo:interval:on:) #496
Conversation
| var values: [Int] = [] | ||
| var completed = false | ||
|
|
||
| original.retry(upTo: Int.max, interval: 1, on: scheduler) |
There was a problem hiding this comment.
Please add a test that tests hitting the uptown limit.
There was a problem hiding this comment.
Thank you for your review so much! I 'll add test!
There was a problem hiding this comment.
I added a test that tests hitting the upto limit.
please see
https://github.com/ReactiveCocoa/ReactiveSwift/pull/496/files#diff-9cd786f9e52e786771d96cf8c42d3befR2018
|
|
||
| context("with interval") { | ||
|
|
||
| it("should send values at the given interval until hitting the limitation") { |
There was a problem hiding this comment.
This isn't a very accurate description of the test. It's testing the retrying, not testing the limitation.
There was a problem hiding this comment.
I see. I updated description of the test. 😄
| var completed = false | ||
|
|
||
| original.retry(upTo: Int.max, interval: 1, on: scheduler) | ||
| .start { event in |
There was a problem hiding this comment.
This indentation is off. The ReactiveSwift style is to have methods like this be indented one stop.
There was a problem hiding this comment.
I fixed indentation 😄
Sources/SignalProducer.swift
Outdated
|
|
||
| retries -= 1 | ||
| return producer | ||
| }.retry(upTo: count) |
There was a problem hiding this comment.
This indentation doesn't match the ReactiveSwift style. It should be indented like so:
return flatMapError { error in
…
}
.retry(upTo: count)There was a problem hiding this comment.
Thank you for your review ! I 'll fix . 😄
|
Thanks for opening a PR! |
|
I updated pull request. Any thoughts? |
Sources/SignalProducer.swift
Outdated
| retries -= 1 | ||
| return producer | ||
| } | ||
| .retry(upTo: count) |
There was a problem hiding this comment.
This is not fully addressed yet.
return flatMapError { error in
…
}
.retry(upTo: count)There was a problem hiding this comment.
Oh, sorry.. I 'll fix soon!
Sources/SignalProducer.swift
Outdated
| retries -= 1 | ||
| return producer | ||
| } | ||
| .retry(upTo: count) |
There was a problem hiding this comment.
Please indent the two lines above as well.
There was a problem hiding this comment.
Thank you for your review and feedback. I sent pull request again. Is this correct?
7a5b7b9
|
|
||
| scheduler.advance(by: .seconds(1)) | ||
| expect(count) == 3 | ||
| expect(values) == [1, 2, 3] |
There was a problem hiding this comment.
Can we verify that the error was sent as well?
There was a problem hiding this comment.
I got it.
I 'll try to add testing of error and update CHANGELOG.
thanks! 😄
There was a problem hiding this comment.
Can we verify that the error was sent as well?
I added test. How about this commit 73d2d4d ?
tjnet
force-pushed
the
deferred_retry_from_rex
branch
from
73d2d4d
to
aeee063
Compare
|
Thanks for the PR! Sorry I've been slow reviewing. It's been a busy few weeks. The Swift 4 linux build failed, but I think that's because it needs to be updated. |
|
Sorry for my late reply.. I deeply appreciate your review and feedback! 😄 |
Checklist
Summary
I implemented #224 and write test code
I'm new to this. Is this correct?
Please review in your free time.