Replace Observer.action
with Observer.send
.
#515
Merged
+44
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal.Observer.action
does not capture theSignal.Observer
it derived from. This might cause issues withSignal
inputs and transformed observer, since these rely on the lifetime of theSignal.Observer
. This also implies a semantic inconsistency betweenaction
and any method reference tosend*
.While patching
Observer.action
is sufficient, it appears to be a great opportunity to hide the closure as an implementation detail, and complete thesend
method family with a new overload taking the event sum type.Checklist