Replace Observer.action with Observer.send.
#515
Merged
+44
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
observer-fix
branch
from
af1f0ae
to
54d1883
Compare
andersio
changed the title
Observer.action should inherit the semantics of the derived Observer.Observer.action with Observer.send.
andersio
force-pushed
the
observer-fix
branch
from
54d1883
to
01005d1
Compare
andersio
force-pushed
the
observer-fix
branch
from
01005d1
to
741c66d
Compare
mdiep
reviewed
Sep 10, 2017
Sources/Observer.swift
Outdated
| @@ -11,9 +11,16 @@ extension Signal { | |||
| /// (typically from a Signal). | |||
| public final class Observer { | |||
| public typealias Action = (Event) -> Void | |||
| private let _action: Action | |||
There was a problem hiding this comment.
This seems like it should be called _send.
|
👍 on the name change |
mdiep
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal.Observer.actiondoes not capture theSignal.Observerit derived from. This might cause issues withSignalinputs and transformed observer, since these rely on the lifetime of theSignal.Observer. This also implies a semantic inconsistency betweenactionand any method reference tosend*.While patching
Observer.actionis sufficient, it appears to be a great opportunity to hide the closure as an implementation detail, and complete thesendmethod family with a new overload taking the event sum type.Checklist