[gardening] Remove old unavailable APIs #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
requested changes
Nov 10, 2017
Sources/Deprecations+Removals.swift
Outdated
|
|
||
| @available(*, unavailable, renamed:"BindingSource") | ||
| public typealias BindingSourceProtocol = BindingSource | ||
| // MARK: Deprecated types in ReactiveSwift 2.x. |
There was a problem hiding this comment.
This probably shouldn't say 2.x?
| public static func += (left: Lifetime, right: () -> Void) -> Disposable? { fatalError() } | ||
|
|
||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `observeEnded(_:)` with a method reference to `dispose()` instead. This method is subject to removal in a future release.") |
There was a problem hiding this comment.
Since this one was only deprecated, it should stay until the next major version and become unavailable.
|
Thanks for cleaning this out. ✨ |
andersio
approved these changes
Nov 11, 2017
andersio
pushed a commit
that referenced
this pull request
Nov 11, 2017
* [gardening] Remove old unavailable APIs * Restore `Lifetime.add(_:)` as an unavailable method * Tweak
andersio
pushed a commit
that referenced
this pull request
Nov 11, 2017
* [gardening] Remove old unavailable APIs * Restore `Lifetime.add(_:)` as an unavailable method * Tweak
andersio
added a commit
that referenced
this pull request
Nov 11, 2017
andersio
added a commit
that referenced
this pull request
Nov 24, 2017
* Enable CI for base branches with `release(-|\/)` prefixes. * [gardening] Remove old unavailable APIs (#551) (#554) * [gardening] Remove old unavailable APIs * Restore `Lifetime.add(_:)` as an unavailable method * Tweak * Update project build schemes and settings. (#553) * [skip ci] Update the documentation. * 3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[ ] Updated CHANGELOG.md.