-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gardening] Remove old unavailable APIs #551
Conversation
Sources/Deprecations+Removals.swift
Outdated
|
||
@available(*, unavailable, renamed:"BindingSource") | ||
public typealias BindingSourceProtocol = BindingSource | ||
// MARK: Deprecated types in ReactiveSwift 2.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably shouldn't say 2.x
?
public static func += (left: Lifetime, right: () -> Void) -> Disposable? { fatalError() } | ||
|
||
@discardableResult | ||
@available(*, deprecated, message:"Use `observeEnded(_:)` with a method reference to `dispose()` instead. This method is subject to removal in a future release.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this one was only deprecated
, it should stay until the next major version and become unavailable
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh overlooked that 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 0a378cb
Thanks for cleaning this out. ✨ |
* [gardening] Remove old unavailable APIs * Restore `Lifetime.add(_:)` as an unavailable method * Tweak
* [gardening] Remove old unavailable APIs * Restore `Lifetime.add(_:)` as an unavailable method * Tweak
* Enable CI for base branches with `release(-|\/)` prefixes. * [gardening] Remove old unavailable APIs (#551) (#554) * [gardening] Remove old unavailable APIs * Restore `Lifetime.add(_:)` as an unavailable method * Tweak * Update project build schemes and settings. (#553) * [skip ci] Update the documentation. * 3.0.0
Checklist
[ ] Updated CHANGELOG.md.