Concat error #564
Merged
Concat error #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2017 15:36
Added a convenience method for concatenating an error to a SignalProducer.
NachoSoto
approved these changes
Nov 24, 2017
|
@NachoSoto good test suggestion! Will add that shortly. |
Added an additional test case to verify that the error of the original signal is emitted - this ensures that concatenated error doesn't override or silence the original error in some way.
nmccann
commented
Nov 24, 2017
| expect(results[3].error) == .default | ||
| } | ||
|
|
||
| it("should emit own error when present") { |
There was a problem hiding this comment.
I'm not quite sure of the wording of this expectation. Thoughts?
There was a problem hiding this comment.
"should not concat the error", perhaps?
There was a problem hiding this comment.
I feel like that contradicts the earlier expectation - unless the reader looks at the implementation. However in my usage of Quick, I try to write expectations that could stand-alone without the implementation and still make sense.
There was a problem hiding this comment.
“should not concat a subsequent error if the earlier producer has failed”?
There was a problem hiding this comment.
"should not emit concatenated error to a failed producer"?
Altered wording of expectation to clarify it's behaviour.
andersio
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
SignalProduceralready supports concatenating a value or a signal, being able to concatenate an error seemed logical. I personally found this useful when implementing a signal that defaulted to an error if nothing matched a filter. For example:Checklist