Add merge(with:) operator #600
Conversation
| /// - returns: A signal that sends all values of `self` and given signal. | ||
| public func merge(with other: Signal<Value, Error>) -> Signal<Value, Error> { | ||
| return Signal.merge(self, other) | ||
| } |
There was a problem hiding this comment.
I think we still ought to have a test for this (and the SignalProducer variant below). Would you mind adding one?
Sources/Flatten.swift
Outdated
| /// - parameters: | ||
| /// - signals: A sequence of signals to merge. | ||
| /// Merges the values of all the given signals, in the manner described | ||
| /// by `merge(with:)`. |
There was a problem hiding this comment.
Normally I wouldn't mind this, but Xcode does not make it easy to find this documentation, so I'd keep it duplicated.
There was a problem hiding this comment.
hmm, I was according to zip, combineLatest operator, though should revert?
There was a problem hiding this comment.
We should duplicate it in those too IMO (at least until SourceKit & CMD+Click actually works consistently in Xcode). For now can you keep these how they were?
There was a problem hiding this comment.
gotcha, will revert them:+1:
Write the doc for zip and combineLatest, will too much lines.
I think there are pros and cons, so not to write now.
|
I added tests |
Sources/Flatten.swift
Outdated
| /// - parameters: | ||
| /// - signals: A sequence of signals to merge. | ||
| /// Merges the values of all the given signals, in the manner described | ||
| /// by `merge(with:)`. |
There was a problem hiding this comment.
We should duplicate it in those too IMO (at least until SourceKit & CMD+Click actually works consistently in Xcode). For now can you keep these how they were?
|
|
||
| let mergedSignals = Signal.merge([signal1, signal2]) | ||
| let mergedSignals = Signal.merge([signal1, signal2, signal3]) |
There was a problem hiding this comment.
Thanks for making this more complex now 👍
|
Awesome! Thanks for adding this. 🤘 |
Refer #597
Checklist