Add conformance to SignalProducerConvertible for Result #606
Conversation
|
That's a neat idea! Any chance you can add a few tests for this? |
|
I didn't because there isn't any current conformance tests at all, but I can. |
Sources/ResultExtensions.swift
Outdated
|
|
||
| extension Result: SignalProducerConvertible { | ||
| public var producer: SignalProducer<Value, Error> { | ||
| switch self { |
There was a problem hiding this comment.
You can use the initializer here:
ReactiveSwift/Sources/SignalProducer.swift
Line 156 in 55ac251
There was a problem hiding this comment.
Will do, but perhaps that should now be deprecated in favour of using the protocol?
|
@NachoSoto Tests added. |
| @@ -484,6 +484,34 @@ class SignalProducerSpec: QuickSpec { | |||
| expect(error) == operationError | |||
| } | |||
| } | |||
|
|
|||
| describe("init(_:) base") { | |||
There was a problem hiding this comment.
This should be Result.producer, right?
There was a problem hiding this comment.
Well technically I'm testing SignalProducer.init(_ base:) as well but I can call it Result.producer.
| error = $0 | ||
| } | ||
|
|
||
| expect(error).to(beNil()) |
There was a problem hiding this comment.
You should check that the value was sent, and that it completed.
|
@NachoSoto Amended tests to address comments. |
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # master | |||
| *Please add new entries at the top.* | |||
|
|
|||
| 1. New conformance of `Result` to `SignalProducerConvertible` (#606, kudos to @Qata) | |||
There was a problem hiding this comment.
Perhaps this?
Resultnow interoperates withSignalProducern-ary operators as a constant producer.
|
@andersio Amended |
Checklist
This implements the suggestion in Improve interoperability with
Result. #409