Create Bag with initial elements #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
approved these changes
Feb 19, 2018
Sources/Bag.swift
Outdated
| public init<S: Sequence>(_ elements: S) where S.Iterator.Element == Element { | ||
| nextToken = Token(value: UInt64(elements.underestimatedCount)) | ||
| tokens = ContiguousArray(0..<nextToken.value) | ||
| self.elements = ContiguousArray(elements) |
There was a problem hiding this comment.
Be consistent here: either self for all or none.
There was a problem hiding this comment.
will do.
elements is used as a parameter name, so I'll add self to all.
| bag.insert(disposable) | ||
| } | ||
|
|
||
| let bag = Bag(disposables) |
andersio
requested changes
Feb 20, 2018
Sources/Bag.swift
Outdated
| } | ||
|
|
||
| public init<S: Sequence>(_ elements: S) where S.Iterator.Element == Element { | ||
| self.nextToken = Token(value: UInt64(elements.underestimatedCount)) |
There was a problem hiding this comment.
underestimatedCount is not guaranteed to equal the exact number of elements. We should derive this from the ContiguousArray constructed from elements.
mdiep
approved these changes
Feb 20, 2018
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi✋
I made it possible to create Bag with initial elements, and CompositeDisposable also improved accordingly.
Probably conflicts with #608, but I fix after either is merged.
Checklist