Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Merge SignalProducerConvertibles #610

Merged
merged 5 commits into from
Feb 22, 2018
Merged

[Proposal] Merge SignalProducerConvertibles #610

merged 5 commits into from
Feb 22, 2018

Conversation

ra1028
Copy link
Contributor

@ra1028 ra1028 commented Feb 19, 2018 •
edited

Make SignalProducer.merge to accepts n-ary generic type that conformed to SignalProducerConvertible.
If this is acceptable, how about to write high-arity operators(merge,zip, and combineLatest) into files like Merge.swift?

Checklist

  • Updated CHANGELOG.md.

@ra1028 ra1028 force-pushed the feature/merge-signalproducerconvertible branch from 23b8e7c to a28eb87 Compare February 19, 2018 17:29
@andersio
Copy link
Member

Yes, this is something missed in #351. I believe there are a few missed operators too.

@ra1028
Copy link
Contributor Author

ra1028 commented Feb 20, 2018

@andersio
Is that these operators and initializers?
SignalProducer.concat, SignalProducer.prefix, SignalProducer.flatMapError, Signal.flatMapError, Signal.withLatest, SignalProducer.then, Property.init(initial:values:), Action.init(state:enableIf:execute:), Action.init(state:execute:), Action.init(enableIf:execute:), Action.init(unwrapping:execute:), Action.init(execute:)

@andersio
Copy link
Member

andersio commented Feb 21, 2018 •
edited

@ra1028 Yes, except for Action which is rather pointless to use SignalProducerConvertible.

@ra1028
Copy link
Contributor Author

ra1028 commented Feb 22, 2018

@andersio
ok
will make a PR separately.

andersio
andersio requested changes Feb 22, 2018
View reviewed changes
CHANGELOG.md Outdated
@@ -4,6 +4,7 @@
1. New property operator: `filter` (#586, kudos to @iv-mexx)
1. New operator `merge(with:)` (#600, kudos to @ra1028)
1. New operator `map(value:)` (#601, kudos to @ra1028)
1. `SignalProducer.merge` is now accept any generic type that conformed to `SignalProducerConvertible` (#610, kudos to @1028)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SignalProducer.merge now accepts any combination of SignalProducerConvertible conforming types.

@andersio
Copy link
Member

LGTM otherwise.

@andersio andersio merged commit 6bdca15 into ReactiveCocoa:master Feb 22, 2018
@ra1028 ra1028 deleted the feature/merge-signalproducerconvertible branch February 22, 2018 20:50
@ra1028 ra1028 mentioned this pull request Feb 22, 2018
Merged
1 task
@andersio andersio mentioned this pull request Feb 22, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersio andersio andersio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ra1028 @andersio @ikesyo