-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Merge SignalProducerConvertibles #610
[Proposal] Merge SignalProducerConvertibles #610
Conversation
23b8e7c
to
a28eb87
Compare
Yes, this is something missed in #351. I believe there are a few missed operators too. |
@andersio |
@ra1028 Yes, except for |
@andersio |
CHANGELOG.md
Outdated
@@ -4,6 +4,7 @@ | |||
1. New property operator: `filter` (#586, kudos to @iv-mexx) | |||
1. New operator `merge(with:)` (#600, kudos to @ra1028) | |||
1. New operator `map(value:)` (#601, kudos to @ra1028) | |||
1. `SignalProducer.merge` is now accept any generic type that conformed to `SignalProducerConvertible` (#610, kudos to @1028) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SignalProducer.merge
now accepts any combination ofSignalProducerConvertible
conforming types.
LGTM otherwise. |
Make
SignalProducer.merge
to accepts n-ary generic type that conformed toSignalProducerConvertible
.If this is acceptable, how about to write high-arity operators(merge,zip, and combineLatest) into files like
Merge.swift
?Checklist