-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 10 support #644
Xcode 10 support #644
Changes from 5 commits
c893f4f
e27310d
70b3299
9d39746
eb2bae1
794bcd6
e78bcf6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
github "jspahrsummers/xcconfigs" == 0.12 | ||
github "Quick/Quick" ~> 1.2 | ||
github "Quick/Nimble" ~> 7.0.3 | ||
github "Quick/Nimble" ~> 7.1.2 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
github "Quick/Nimble" "v7.1.1" | ||
github "Quick/Nimble" "v7.1.2" | ||
github "Quick/Quick" "v1.3.0" | ||
github "antitypical/Result" "4.0.0" | ||
github "jspahrsummers/xcconfigs" "0.12" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -178,26 +178,6 @@ public final class ValidatingProperty<Value, ValidationError: Swift.Error>: Muta | |
self.init(MutableProperty(initial), with: other, validator) | ||
} | ||
|
||
/// Create a `ValidatingProperty` that presents a mutable validating | ||
/// view for an inner mutable property. | ||
/// | ||
/// The proposed value is only committed when `valid` is returned by the | ||
/// `validator` closure. | ||
/// | ||
/// - note: `inner` is retained by the created property. | ||
/// | ||
/// - parameters: | ||
/// - inner: The inner property which validated values are committed to. | ||
/// - other: The property that `validator` depends on. | ||
/// - validator: The closure to invoke for any proposed value to `self`. | ||
public convenience init<U, E>( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This changes the semantic. This overload was supposed to be the primary one, and the removed one here should have been implemented in terms of that. Edit: Dropping down to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So what should be done here to avoid the compilation error instead of the removal? @andersio There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Feel free pushing your changes on this branch. |
||
_ inner: MutableProperty<Value>, | ||
with other: ValidatingProperty<U, E>, | ||
_ validator: @escaping (Value, U) -> Decision | ||
) { | ||
self.init(inner, with: other, validator) | ||
} | ||
|
||
/// Create a `ValidatingProperty` that validates mutations before | ||
/// committing them. | ||
/// | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2791,7 +2791,7 @@ class SignalProducerSpec: QuickSpec { | |
let producer = SignalProducer<Int, NoError>.never | ||
.on(disposed: { disposed = true }) | ||
|
||
var replayedProducer = ImplicitlyUnwrappedOptional(producer.replayLazily(upTo: 1)) | ||
var replayedProducer = Optional(producer.replayLazily(upTo: 1)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So we were using it as a regular optional anyway? Huh. |
||
|
||
expect(disposed) == false | ||
let disposable1 = replayedProducer?.start() | ||
|
@@ -2814,7 +2814,7 @@ class SignalProducerSpec: QuickSpec { | |
let producer = SignalProducer<Int, NoError>.never | ||
.on(disposed: { disposed = true }) | ||
|
||
var replayedProducer = ImplicitlyUnwrappedOptional(producer.replayLazily(upTo: 1)) | ||
var replayedProducer = Optional(producer.replayLazily(upTo: 1)) | ||
|
||
expect(disposed) == false | ||
let disposable = replayedProducer?.start() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The capture of the compiler error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following overload will be used instead after this removal:
ReactiveSwift/Sources/ValidatingProperty.swift
Lines 128 to 132 in 7c25bc2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense 👍