-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Quick to 2.0.0 and Nimble to 8.0.0 #711
Conversation
I think the deployment target of the macOS tests will need to be changed to 10.10 to match Quick/Nimble. |
CI for Xcode 9.4 can be removed. |
99f1ffc
to
f2f5e5e
Compare
@@ -1278,7 +1278,7 @@ | |||
CURRENT_PROJECT_VERSION = 1; | |||
ENABLE_TESTABILITY = YES; | |||
IPHONEOS_DEPLOYMENT_TARGET = 8.0; | |||
MACOSX_DEPLOYMENT_TARGET = 10.9; | |||
MACOSX_DEPLOYMENT_TARGET = 10.10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the deployment target of just the test target and leave the framework's deployment target at 10.9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll address that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8bdcc81.
f2f5e5e
to
595a1ba
Compare
This is required to build using Xcode 10.2. But we require Swift 4.2 at least now, so we must drop Swift 4.1 support.
Checklist
[ ] Updated CHANGELOG.md.