Add possibility to use and + or with collection of signals/properties
#735
+314
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
requested changes
May 14, 2019
Sources/FoundationExtensions.swift
Outdated
| internal func and() -> Bool { | ||
| return reduce(true) { $0 && $1 } | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd prefer not to add these extensions. They pollute the namespace and aren't used widely enough to justify that—nor do they add that much over .reduce(true, &&).
Sources/Property.swift
Outdated
| /// - property: Collection of properties to be combined. | ||
| /// | ||
| /// - returns: A property that contains the logial AND results. | ||
| public static func and<P: PropertyProtocol, Properties: Collection>(_ properties: Properties) -> Property<Value> where P.Value == Value, Properties.Element == P { |
There was a problem hiding this comment.
all seems like a better name for this
Sources/Property.swift
Outdated
| /// - properties: Collection of properties to be combined. | ||
| /// | ||
| /// - returns: A property that contains the logial OR results. | ||
| public static func or<P: PropertyProtocol, Properties: Collection>(_ properties: Properties) -> Property<Value> where P.Value == Value, Properties.Element == P { |
There was a problem hiding this comment.
any seems like a better name for this
|
Thanks for the review, all issues should be resolved now. |
mdiep
requested changes
May 15, 2019
| 1. add possibility to use `and` and `or` operators with array of arguments (#735, kudos to @olejnjak) | ||
| ```swift | ||
| let property = Property.or([boolProperty1, boolProperty2, boolProperty3]) | ||
| ``` |
There was a problem hiding this comment.
This needs to be updated now
mdiep
approved these changes
May 15, 2019
|
Looks good to me. I'll leave this open for a day or two in case anyone else has feedback. |
|
Thanks! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually on my projects I do use more properties to determine state of some
Property, e.g.isLoadingproperty usually depends on more properties which later on ends like thisThen I end up with extensions which simplify such code and I think it might be useful for more people than just me.
This PR adds static function
andandortoSignalProducer,PropertyProtocolwith appropriate attributes which solves such case elegantly.Checklist