Cherry-pick fix for Xcode 11 #742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes compilation on `Xcode 11` / `Swift 5.1`.
|
I guess if we decide to accept this change, we could tag 44f9c68 (or whatever commit ends up as the tip of this branch) as 6.0.1 and merge back to master? |
|
I think we could just release (Technically, it should be 7.0 because of #733, but I'm inclined to call that a bug and ship it as a 6.x. Not sure what anyone else thinks.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks #739 onto a new branch based on 6.0.0. Was thinking it might be nice to release a patch for Swift 5.1 support without including the new features on master.
Checklist