Fix debounce when started twice #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test now fails so I can make sure my fix works.
Now all tests pass!
|
@andersio not sure why this test failed ci: It seems go only fail sometimes when I run the tests locally, might be indicative of a performance issue or just poor cpu management at the time it ran. Adding a |
|
@gpambrozio It is general flakiness of asynchronous test IMO. It can be rewritten it in terms of |
|
@andersio do you want me to add the |
|
@gpambrozio It wouldn't be necessary. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #771. Thanks @andersio for the quick solution on this.
I also added tests that show the solution works. The tests were added at a commit before the change that fixed it so it's easy to verify that tests fail before the change but not after.
Checklist