Increased performance of joining signals by a factor of around 5 #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2020 15:13
…is becomes relevant, when joining a 1000 signals and more
rocketnik
changed the title
andersio
approved these changes
Feb 17, 2020
andersio
reviewed
Feb 17, 2020
| @@ -1680,7 +1680,7 @@ extension Signal { | |||
| return true | |||
| } | |||
|
|
|||
| _haveAllSentInitial = values.reduce(true) { $0 && !($1 is Placeholder) } | |||
| _haveAllSentInitial = values.allSatisfy{ !($0 is Placeholder) } | |||
There was a problem hiding this comment.
Suggested change
| _haveAllSentInitial = values.allSatisfy{ !($0 is Placeholder) } | |
| _haveAllSentInitial = values.allSatisfy { !($0 is Placeholder) } |
rocketnik
pushed a commit
to rocket-internet-berlin/ReactiveSwift
that referenced
this pull request
Feb 18, 2020
Increased performance of joining signals by a factor of around 5 (ReactiveCocoa#773)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this becomes relevant, when joining 1000 signals and more
Checklist
✅ Updated CHANGELOG.md.