Mark Property and MutableProperty as property wrappers. #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mluisbrown
approved these changes
May 22, 2020
RuiAAPeres
approved these changes
May 22, 2020
1 task
This was referenced Jun 12, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant context: #762 (comment)
These types would not go away even if we continue to evolve #762, and marking them as property wrapper is a reasonable transitional solution to improve QoL until that happens.
PropertyandMutablePropertycan be used as property wrappers without controversy IMO — they will continue to be reference type containers, so there is no surprise awaiting new RAS users.Checklist