Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop declaring Swift 5.0 support. #794

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Stop declaring Swift 5.0 support. #794

merged 2 commits into from
Aug 15, 2020

Conversation

andersio
Copy link
Member

We have adopted @propertyWrapper which requires Swift 5.1+.

Checklist

  • Updated CHANGELOG.md.

@andersio andersio self-assigned this Jun 10, 2020
@mluisbrown
Copy link
Contributor

Doesn't it require Swift 5.2? In Package.swift you have // swift-tools-version:5.2 which forces the use of Swift 5.2. I'm currently having that issue in the ReactiveSwift TCA, so I have to declare only Swift 5.2 support (and therefore only Xcode 11.4 and 11.5 support).

If 5.2 is not required, it would be great to change the Package declaration to reflect this too 🙏

@andersio
Copy link
Member Author

@mluisbrown It was bumped to swift-tools-version:5.2 because 5.2 contains SwiftPM fixes around test dependencies. #784

@mluisbrown
Copy link
Contributor

ok, so the SPM version has to remain 5.2 😢 Fair enough.

@andersio andersio merged commit e4dbe09 into master Aug 15, 2020
@andersio andersio deleted the anders/podspec branch August 15, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mluisbrown mluisbrown mluisbrown approved these changes

Assignees

@andersio andersio

Labels
ci:verify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersio @mluisbrown